Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BFW-5530] gui: Fix german language issue with Filament Color layout and First setup #3614

Merged
merged 1 commit into from
May 20, 2024

Conversation

bkerler
Copy link
Contributor

@bkerler bkerler commented Dec 18, 2023

Fix german language issue with Filament Color layout, related to issue #3611 and First setup screen.

The filament color change screen before:
image

Now:
image

The setup wizard screen was modified as well to fix the broken display layout.

Previous setup wizard:
image

Now:
image

@bkerler bkerler changed the title Fix german language issue with Filament Color layout and First setup … gui: Fix german language issue with Filament Color layout and First setup Dec 21, 2023
@Hayajiro
Copy link

I'd love seeing this getting merged (the members of our FabLab are joking about this), but I guess one reason why this has been lying around since December is the incorrect commit history. Instead of rebasing your changes with master, you merged master your branch, resulting in duplicate commits.

@bkerler
Copy link
Contributor Author

bkerler commented Feb 18, 2024

@Hayajiro I normally always base against master, but it was a decision to base against v5.1.2 by one of the Prusa Developers. GUI changes have to go through several departments, that's why it is taking quite long.

@danopernis danopernis changed the title gui: Fix german language issue with Filament Color layout and First setup [BFW-5530] gui: Fix german language issue with Filament Color layout and First setup May 20, 2024
@danopernis danopernis merged commit 991dd60 into prusa3d:master May 20, 2024
1 check passed
@bkerler bkerler deleted the de_lang_fix branch May 20, 2024 11:18
@marcel151
Copy link

marcel151 commented Jun 8, 2024

Why the "Plenk" (blank before the question mark), though? Please, that looks just stupid and other than that, it's wrong.

@foorschtbar
Copy link
Contributor

Why the "Plenk" (blank before the question mark), though? Please, that looks just stupid and other than that, it's wrong.

Not stupid - thats a hard word! - but wrong. PR with fix is opened #4136 :)

@marcel151
Copy link

marcel151 commented Aug 15, 2024

Why the "Plenk" (blank before the question mark), though? Please, that looks just stupid and other than that, it's wrong.

Not stupid - thats a hard word! - but wrong. PR with fix is opened #4136 :)

That's what I (also) said. ;-) It always looks stupid for me, sorry if I'm that harsh. I never understand why people do that. It's more work (you have to press space), it looks unpleasant and for the most part, it's wrong. Maybe somebody knows why people do it.
Thank you for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translations language packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants